lib/commit: (refactor) Clean up delta bare write API #1283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way `_ostree_repo_open_content_bare()` did both looking for the object and possibly creating a new fd was just weird and inconsistent with e.g. the pull code where we always call `has_object()` first. Just call `has_object()` in the delta paths that used this too, making the implementation right now a thin wrapper around `glnx_open_tmpfile_linkable_at()`, but this is prep for a later patch which does more.
jlebon
reviewed
Oct 18, 2017
| @@ -412,23 +412,9 @@ _ostree_repo_open_content_bare (OstreeRepo *self, | |||
| const char *checksum, | |||
There was a problem hiding this comment.
Can we update the preceding comment block too?
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way
_ostree_repo_open_content_bare()did both looking for the object andpossibly creating a new fd was just weird and inconsistent with e.g. the pull
code where we always call
has_object()first.Just call
has_object()in the delta paths that used this too, making theimplementation right now a thin wrapper around
glnx_open_tmpfile_linkable_at(), but this is prep for a later patch which doesmore.