ci: Record primary context results using g-d-t-r --report-directory #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
ci-gdtr-report-directory
branch
from
f436416 to
c798d42
Compare
|
Blah, really just need to fix g-d-t-r to have a saner option to record the output even for successful tests. |
gnomesysadmins
pushed a commit
to GNOME/gnome-desktop-testing
that referenced
this pull request
Sep 27, 2017
This contains just the test output (stdout/stderr), and is always generated even on success. This is really what we want for libostree at least; see ostreedev/ostree#1218
cgwalters
force-pushed
the
ci-gdtr-report-directory
branch
from
c798d42 to
4eb85ad
Compare
pwithnall
reviewed
Sep 27, 2017
Ahhh right. |
cgwalters
force-pushed
the
ci-gdtr-report-directory
branch
from
6f50ba6 to
70473e1
Compare
jlebon
reviewed
Sep 27, 2017
ci/build-check.sh
Outdated
| # Keep this in sync with papr.yml | ||
| # TODO; Split the main/clang builds into separate build dirs | ||
| for x in test-suite.log config.log gdtr-results; do | ||
| if test -e ${x}; then |
There was a problem hiding this comment.
This should be test -e ${resultsdir}/${x} right?
cgwalters
force-pushed
the
ci-gdtr-report-directory
branch
from
af5e572 to
33288b9
Compare
|
Looks like it worked! Though that last fixup is still targeting the wrong commit. |
So the output isn't all intermingled. I just pushed a commit to add `--log-directory`, so we need to build it from git master for now.
cgwalters
force-pushed
the
ci-gdtr-report-directory
branch
from
33288b9 to
ee61d31
Compare
|
"I know, I'll use regular expressions!" ... cgwalters/homegit@db05a91 |
|
☀️ Test successful - status-atomicjenkins |
jlebon
added a commit
to jlebon/ostree
that referenced
this pull request
Sep 28, 2017
This was originally part of ostreedev#1199, but never got in. The work in ostreedev#1218 is awesome for CI, though for the developer workflow, I find it much easier to just set $TEST_TMPDIR to a non-overlayfs mount point. Teach the test libraries to just look at $PWD rather than /. Also export the function that does the overlayfs checking. Prep for a future patch.
rh-atomic-bot
pushed a commit
that referenced
this pull request
Sep 28, 2017
This was originally part of #1199, but never got in. The work in #1218 is awesome for CI, though for the developer workflow, I find it much easier to just set $TEST_TMPDIR to a non-overlayfs mount point. Teach the test libraries to just look at $PWD rather than /. Also export the function that does the overlayfs checking. Prep for a future patch. Closes: #1170 Approved by: cgwalters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the output isn't all intermingled. Yes, need to improve g-d-t-r.