tests: Add a manual integration test for OstreeRepoFinderMount #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwithnall
force-pushed
the
repo-finder-mount-integration
branch
3 times, most recently
from
3d2f961 to
c522681
Compare
|
Summary of what @cgwalters and I discussed today:
|
pwithnall
force-pushed
the
repo-finder-mount-integration
branch
2 times, most recently
from
4553587 to
af7c1f7
Compare
|
☔ The latest upstream changes (presumably 2f9f722) made this pull request unmergeable. Please resolve the merge conflicts. |
pwithnall
force-pushed
the
repo-finder-mount-integration
branch
from
af7c1f7 to
fe6bb0a
Compare
Test an end-to-end flow of pulling refs from an online repository → local OS repository → create a USB stick of them → pull to a local OS repository on another machine. This is a manual test, as it requires a throwaway USB stick which the test can format as ext4 or vfat to test the flow works with both file systems. Run it as: MOUNT_INTEGRATION_DEV=/dev/sdb1 make check \ TESTS=tests/test-repo-finder-mount-integration.sh Signed-off-by: Philip Withnall <[email protected]>
The latter is deprecated now. Signed-off-by: Philip Withnall <[email protected]>
As per commit 6e4146a. Signed-off-by: Philip Withnall <[email protected]>
pwithnall
force-pushed
the
repo-finder-mount-integration
branch
from
fe6bb0a to
a3b1813
Compare
|
Rebased on master now that #1202 has been merged. Ready for review and merging. |
|
Nice work! At a quick glance at the test I think I know how to get this wired up, though the udisks bit may be tricky. Anyways can do later. |
|
⚡ Test exempted: pull fully rebased and already tested. |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Sep 28, 2017
The latter is deprecated now. Signed-off-by: Philip Withnall <[email protected]> Closes: #1203 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
Sep 28, 2017
As per commit 6e4146a. Signed-off-by: Philip Withnall <[email protected]> Closes: #1203 Approved by: cgwalters
|
⚡️ ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test an end-to-end flow of pulling refs from an online
repository → local OS repository → create a USB stick of
them → pull to a local OS repository on another machine.
This is a manual test, as it requires a throwaway USB stick which the
test can format as ext4 or vfat to test the flow works with both file
systems.
Run it as:
MOUNT_INTEGRATION_DEV=/dev/sdb1 make check
TESTS=tests/test-repo-finder-mount-integration.sh
Signed-off-by: Philip Withnall [email protected]
This PR depends on fixes from #1202. It exercises some of the functionality introduced in #1182, so it also depends (transitively) on that.