lib/syslinux: Port to new code style #1154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was only one tricky bit here around the ownership of the lines; I made use of `g_steal_pointer()` to consistently track ownership, and converted to a `for` loop while still preserving the loop logic around the last entry.
jlebon
reviewed
Sep 8, 2017
| { | ||
| char *line = *iter; | ||
| /* Take ownership of the string element */ | ||
| g_autofree char *line = g_steal_pointer (iter); |
There was a problem hiding this comment.
Hmm, there's a subtle issue here (which looks like it existed even before). g_strfreev stops at the first NULL it finds. If we break out of this loop earlier than expected, the remaining strings will never be freed, right? It seems like it's simpler to just g_strdup in that case?
There was a problem hiding this comment.
Yeah, you're right. Updated, also did some more re-indent while there ⬇️
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was only one tricky bit here around the ownership of the lines; I made use
of
g_steal_pointer()to consistently track ownership, and converted to aforloop while still preserving the loop logic around the last entry.