Incorrect check for static configs with bootupd #3295
Labels
Comments
travier
added a commit
to travier/ostree
that referenced
this issue
Sep 13, 2024
In ostreedev#3205, we introduced a check to skip re-generating the GRUB config if we detect that static configs are in used by looking at bootupd's state. Unfortunately this check is incomplete and does not account for present but null entries in the JSON state file. A proper fix would be to parse the JSON but this requires a larger code change. Fixes: ostreedev#3295 Fixes: ostreedev#3205
travier
added a commit
to travier/ostree
that referenced
this issue
Sep 13, 2024
In ostreedev#3205, we introduced a check to skip re-generating the GRUB config if we detect that static configs are in used by looking at bootupd's state. Unfortunately this check is incomplete and does not account for present but null entries in the JSON state file. A proper fix would be to parse the JSON but this requires a larger code change. Fixes: ostreedev#3295 Fixes: ostreedev#3205
travier
added a commit
to travier/ostree
that referenced
this issue
Sep 13, 2024
In ostreedev#3205, we introduced a check to skip re-generating the GRUB config if we detect that static configs are in used by looking at bootupd's state. Unfortunately this check is incomplete and does not account for present but null entries in the JSON state file. A proper fix would be to parse the JSON but this requires a larger code change. Fixes: ostreedev#3295 Fixes: ostreedev#3205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#3205 added a check that looks for
"static-configs"in bootupd state file:/boot/bootupd-state.json.Unfortunately, bootup will always write this entry (even if null) since coreos/bootupd#609.
This is likely the source of fedora-silverblue/issue-tracker#595.
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2312453
The text was updated successfully, but these errors were encountered: