libostree: new repo configuration payload-link-threshold

sets a minimum file size threshold for payload link files to be created. A payload-link file is created only for bigger that are >= payload-link-threshold. By default the payload-link-threshold value is G_MAXUINT64 that disables the feature. Signed-off-by: Giuseppe Scrivano <[email protected]>
ostreedev · Feb 14, 2018 · 5c1a2a0 · 5c1a2a0
1 parent 46f3278
commit 5c1a2a0
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 1 deletion.
diff --git a/man/ostree.repo-config.xml b/man/ostree.repo-config.xml
@@ -145,6 +145,13 @@ Boston, MA 02111-1307, USA.
         </listitem>
       </varlistentry>
 
+      <varlistentry>
+        <term><varname>payload-link-threshold</varname></term>
+        <listitem><para>An integer value that specifies a minimum file size for creating
+        a payload link.  By default it is disabled.
+        </para></listitem>
+      </varlistentry>
+
     </variablelist>
   </refsect1>
 

diff --git a/src/libostree/ostree-repo-commit.c b/src/libostree/ostree-repo-commit.c
@@ -919,7 +919,7 @@ write_content_object (OstreeRepo         *self,
                                         cancellable, error))
         return FALSE;
 
-      if (!has_payload_object && actual_payload_checksum)
+      if (!has_payload_object && actual_payload_checksum && g_file_info_get_size (file_info) >= self->payload_link_threshold)
         {
           if (symlinkat (actual_checksum, commit_tmp_dfd (self), actual_payload_checksum) < 0)
             {

diff --git a/src/libostree/ostree-repo-private.h b/src/libostree/ostree-repo-private.h
@@ -161,6 +161,7 @@ struct OstreeRepo {
   gchar *collection_id;
   gboolean add_remotes_config_dir; /* Add new remotes in remotes.d dir */
   gint lock_timeout_seconds;
+  guint64 payload_link_threshold;
 
   OstreeRepo *parent_repo;
 };

diff --git a/src/libostree/ostree-repo.c b/src/libostree/ostree-repo.c
@@ -2827,6 +2827,15 @@ reload_core_config (OstreeRepo          *self,
       return FALSE;
   }
 
+  { g_autofree char *payload_threshold = NULL;
+
+    if (!ot_keyfile_get_value_with_default (self->config, "core", "payload-link-threshold", "-1",
+                                            &payload_threshold, error))
+      return FALSE;
+
+    self->payload_link_threshold = g_ascii_strtoull (payload_threshold, NULL, 10);
+  }
+
   return TRUE;
 }