-
Notifications
You must be signed in to change notification settings - Fork 310
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
repo: Add archive/zlib-level option, drop default compression to 6
The gzip default is 6. When I was writing this code, I chose 9 under the assumption that for long-term archival, the extra compression was worth it. Turns out level 9 is really, really not worth it. Here's run at level 9 compressing the current Fedora Atomic Host into archive: ``` ostree --repo=repo pull-local repo-build fedora-atomic/25/x86_64/docker-host real 2m38.115s user 2m31.210s sys 0m3.114s 617M repo ``` And here's the new default level of 6: ``` ostree --repo=repo pull-local repo-build fedora-atomic/25/x86_64/docker-host real 0m53.712s user 0m43.727s sys 0m3.601s 619M repo 619M total ``` As you can see, we run almost *three times* faster, and we take up *less than one percent* more space. Conclusion: Using level 9 is dumb. And here's a run at compression level 1: ``` ostree --repo=repo pull-local repo-build fedora-atomic/25/x86_64/docker-host real 0m24.073s user 0m17.574s sys 0m2.636s 643M repo 643M total ``` I would argue actually many people would prefer even this for "devel" repos. For production repos, you want static deltas anyways. (However, perhaps we should support a model where generating a delta involves re-compressing fallback objects with a bit stronger compression level). Anyways, let's make everyone's life better and switch the default to 6. Closes: #671 Approved by: jlebon
- Loading branch information
1 parent
9169268
commit 3d38f03
Showing
5 changed files
with
61 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters