Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed 'else if' clause for google-services.json copying #2

Merged
merged 1 commit into from
Sep 4, 2017
Merged

Removed 'else if' clause for google-services.json copying #2

merged 1 commit into from
Sep 4, 2017

Conversation

chrisjpalmer
Copy link
Collaborator

This commit enables the ROOT/platforms/android/google-services.json file to ALWAYS reflect the ROOT/google-services.json even if you have an iOS project. This is particularly important if you have multiple branches in your cordova project, each one having a different a google-services.json configuration (different firebase apps). Switching between branches and then calling cordova build would (previously) not update the platforms/android/google-services.json to the one that is actually in the root dir of the branch. Instead it retains the old google-services.json.

This results in the wrong google-services.json being loaded into the application at build time.

This commit enables the ROOT/platforms/android/google-services.json file to ALWAYS reflect the ROOT/google-services.json even if you have an iOS project. This is particularly important if you have multiple branches in your cordova project, each one having a different a google-services.json configuration (different firebase apps). Switching between branches and then calling `cordova build` would (previously) not update the platforms/android/google-services.json to the one that is actually in the root dir of the branch. Instead it retains the old google-services.json.

This results in the wrong google-services.json being loaded into the application at build time.
@ostownsville ostownsville merged commit 925d597 into ostownsville:master Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants