Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix map filter with slice of structs #71

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Fix map filter with slice of structs #71

merged 1 commit into from
Aug 23, 2023

Conversation

ofavre
Copy link
Contributor

@ofavre ofavre commented Sep 16, 2022

The previous map implementation worked only for slices of maps. By using the library's values package this implementation should work with all compatible types.

Checklist

  • I have read the contribution guidelines.
  • make test passes.
  • make lint passes. (at least on modified files)
  • New and changed code is covered by tests.
  • Performance improvements include benchmarks.
  • Changes match the documented (not just the implemented) behavior of Shopify.

@ofavre
Fix map filter with slice of structs
4d1de3d 
The previous map implementation worked only for slices of maps.
By using the library's `values` package this implementation should work
with all compatible types.
@danog danog merged commit ddc76a5 into osteele:main Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ofavre @danog