Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count number of characters in size filter instead of number of bytes #101

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

jamslinger
Copy link
Contributor

Checklist

  • I have read the contribution guidelines.
  • make test passes.
  • make lint passes.
  • New and changed code is covered by tests.
  • Performance improvements include benchmarks.
  • Changes match the documented (not just the implemented) behavior of Shopify.

@jamslinger
Copy link
Contributor Author

Fixes #100

@danog
Copy link
Collaborator

danog commented Oct 19, 2024

Thanks!

@danog danog merged commit c1f5e56 into osteele:main Oct 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants