For #1612, fix crash bug for RTSP. 4.0.12

ossrs · Mar 7, 2020 · dcb0553 · dcb0553
1 parent 12a7432
commit dcb0553
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -153,6 +153,7 @@ For previous versions, please read:
 
 ## V4 changes
 
+* v4.0, 2020-03-07, For [#1612][bug #1612], fix crash bug for RTSP. 4.0.12
 * v4.0, 2020-03-07, For [#1631][bug #1631], support sei_filter for SRT. 4.0.11
 * v4.0, 2020-03-01, For [#1621][bug #1621], support mix_correct for aggregate aac for SRT. 4.0.10
 * v4.0, 2020-02-25, For [#1615][bug #1615], support default app(live) for vmix SRT. 4.0.9
@@ -1693,6 +1694,7 @@ Winlin
 [bug #xxxxxxxxxxxxx]: https://github.com/ossrs/srs/issues/xxxxxxxxxxxxx
 
 [bug #1631]: https://github.com/ossrs/srs/issues/1631
+[bug #1612]: https://github.com/ossrs/srs/issues/1612
 [bug #xxxxxxxxxxxxx]: https://github.com/ossrs/srs/issues/xxxxxxxxxxxxx
 
 [exo #828]: https://github.com/google/ExoPlayer/pull/828

diff --git a/trunk/src/app/srs_app_rtsp.cpp b/trunk/src/app/srs_app_rtsp.cpp
@@ -242,6 +242,7 @@ srs_error_t SrsRtspConn::serve()
 
 std::string SrsRtspConn::remote_ip()
 {
+    // TODO: FIXME: Implement it.
     return "";
 }
 

diff --git a/trunk/src/app/srs_app_server.cpp b/trunk/src/app/srs_app_server.cpp
@@ -179,6 +179,8 @@ SrsRtspListener::SrsRtspListener(SrsServer* svr, SrsListenerType t, SrsConfDirec
     srs_assert(type == SrsListenerRtsp);
     if (type == SrsListenerRtsp) {
         caster = new SrsRtspCaster(c);
+
+        // TODO: FIXME: Must check error.
         caster->initialize();
     }
 }

diff --git a/trunk/src/core/srs_core_version4.hpp b/trunk/src/core/srs_core_version4.hpp
@@ -24,6 +24,6 @@
 #ifndef SRS_CORE_VERSION4_HPP
 #define SRS_CORE_VERSION4_HPP
 
-#define SRS_VERSION4_REVISION 11
+#define SRS_VERSION4_REVISION 12
 
 #endif
-Original file line number
+Diff line change
@@ Expand Up / @@ -242,6 +242,7 @@ srs_error_t SrsRtspConn::serve() @@
     std::string SrsRtspConn::remote_ip()
     {
+        // TODO: FIXME: Implement it.
         return "";
     }
@@ Expand Down @@