Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply for SLSA graduation #415

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Apply for SLSA graduation #415

wants to merge 5 commits into from

Conversation

lehors
Copy link
Contributor

@lehors lehors commented Nov 26, 2024

This is an application to recognize the SLSA project (which covers the specification work) as a Graduated project.

Signed-off-by: Arnaud J Le Hors <[email protected]>
@lehors lehors requested a review from a team as a code owner November 26, 2024 13:10
@lehors lehors marked this pull request as draft November 26, 2024 13:11
Signed-off-by: Arnaud J Le Hors <[email protected]>
* https://github.com/slsa-framework/slsa/blob/main/CONTRIBUTING.md#slsa-versions-management

Projects should harden their build systems in accordance with the SLSA Framework
* Not Applicable but we do use features such as branch protection, Dependabot, and Mend Renovate bot.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be looking how to apply SLSA in the builds of our reference implementations (e.g. slsa-github-generator)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but these are in a different project: SLSA Tooling project so we can deal with those separately.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, per our discussion on Slack yesterday, I agree that we ought to handle those separately.


### Security Baseline

The project meets all applicable Security Baseline requirements:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these requirements need to be applied to our demos and reference implementations?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This something that I think we should clarify. I think in SLSA's case it's the spec and the SLSA GitHub generator.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say that the SLSA Jenkins generator is another tool that needs to be included, only if for the relatively wide use of Jenkins.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This application merely refers to the SLSA specification work, the rest is currently in a different project: SLSA Tooling project. The separation dates from when the SLSA spec group was a SIG and it may actually make sense to regroup these into a single project moving forward but I'd rather not delay getting this application processed so let's keep them separated for now.

Copy link
Member

@steiza steiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 minor comments - looking forward to seeing this pull request come out of draft!

* https://github.com/slsa-framework/governance

Have a defined and documented roadmap and annual goals for the project
* https://github.com/slsa-framework/slsa/projects?query=is%3Aopen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first I was skeptical, but this is actually not a bad way to indicate the high-level workstreams a TI is undertaking, especially for a larger project like SLSA!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think one could argue that we are missing specific target dates. We are aiming for SLSA 1.1 to be out by the end of the year but this isn't captured here but otherwise I think it's a pretty good view of what's going on.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be captured here just to meet the metric? The case is strong for graduated status, but we do want to make sure the "I"s are dotted, and "T"s are crossed.

Copy link
Contributor

@marcelamelara marcelamelara Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One way we might track our roadmap is by using GitHub milestones, as we've done in the past. These specifically allow us to set due dates, and to associate specific issues and PR with a milestone to track progress.

Signed-off-by: Arnaud J Le Hors <[email protected]>
Copy link
Contributor

@sevansdell sevansdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and select box for Security Baseline. Must be able to show meet security baseline requirements (could document and link in PR). Also, missing full list of URL table.

Otherwise, all the information prior to that part looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants