-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Allow incomplete local checks #4423
✨ Allow incomplete local checks #4423
Conversation
Signed-off-by: Luke Harrison <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4423 +/- ##
==========================================
+ Coverage 66.80% 68.77% +1.96%
==========================================
Files 230 236 +6
Lines 16602 17577 +975
==========================================
+ Hits 11091 12088 +997
+ Misses 4808 4695 -113
- Partials 703 794 +91 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending a PR, overall looks pretty good! Left a few comments
Signed-off-by: Luke Harrison <[email protected]>
Signed-off-by: Luke Harrison <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I ran this through my local repo with scdiff
, and the changes are working as expected, with the 5 new checks showing up.
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
Certain checks are currently not run when using the
local
optionWhat is the new behavior (if this is a feature change)?**
Now allows incomplete versions of the following checks to be run when using the
local
optionFuzzing
License
Packaging
SAST
Security-Policy
Which issue(s) this PR fixes
Fixes #3832
Special notes for your reviewer
go-git
#1709Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)