Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Allow incomplete local checks #4423

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

lharrison13
Copy link
Contributor

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

Certain checks are currently not run when using the local option

What is the new behavior (if this is a feature change)?**

Now allows incomplete versions of the following checks to be run when using the local option

Fuzzing
License
Packaging
SAST
Security-Policy

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #3832

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

Enabled Fuzzing, License, Packaging, SAST, and Security-Policy checks when using --local option
Screenshot 2024-11-26 at 11 59 38 PM

@lharrison13 lharrison13 requested a review from a team as a code owner November 27, 2024 05:01
@lharrison13 lharrison13 requested review from spencerschrock and raghavkaul and removed request for a team November 27, 2024 05:01
@lharrison13 lharrison13 changed the title ✨ Allow incomplete localdir checks ✨ Allow incomplete local checks Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 24.35897% with 59 lines in your changes missing coverage. Please review.

Project coverage is 68.77%. Comparing base (353ed60) to head (d3e9469).
Report is 65 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4423      +/-   ##
==========================================
+ Coverage   66.80%   68.77%   +1.96%     
==========================================
  Files         230      236       +6     
  Lines       16602    17577     +975     
==========================================
+ Hits        11091    12088     +997     
+ Misses       4808     4695     -113     
- Partials      703      794      +91     

Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a PR, overall looks pretty good! Left a few comments

checks/packaging.go Outdated Show resolved Hide resolved
checks/raw/fuzzing.go Outdated Show resolved Hide resolved
checks/raw/github/packaging.go Outdated Show resolved Hide resolved
checks/raw/security_policy.go Outdated Show resolved Hide resolved
clients/localdir/client.go Outdated Show resolved Hide resolved
policy/policy_test.go Show resolved Hide resolved
Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I ran this through my local repo with scdiff, and the changes are working as expected, with the 5 new checks showing up.

@spencerschrock spencerschrock enabled auto-merge (squash) December 2, 2024 21:06
@spencerschrock spencerschrock merged commit cdfb58b into ossf:main Dec 2, 2024
37 of 38 checks passed
@lharrison13 lharrison13 deleted the local-repo-incomplete-checks branch December 3, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Feature: Allow "incomplete" checks for --local repos
2 participants