Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Skip cosign confirmation prompt during publishimage action. #2918

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

spencerschrock
Copy link
Member

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

the cosign step fails since it asks for a confirmation prompt:

By typing 'y', you attest that (1) you are not submitting the personal data of any other person; and (2) you understand and agree to the statement and the Agreement terms at the URLs listed above.
Are you sure you would like to continue? [y/N] Error: signing [ghcr.io/ossf/scorecard/v4:f3b777086fb670ed5b10b4d1d7257786d0daa6d6]: recursively signing: signing digest: should upload to tlog: user declined the prompt
main.go:74: error during command execution: signing [ghcr.io/ossf/scorecard/v4:f3b777086fb670ed5b10b4d1d7257786d0daa6d6]: recursively signing: signing digest: should upload to tlog: user declined the prompt
Error: Process completed with exit code 1.

What is the new behavior (if this is a feature change)?**

cosign sign is called with the --yes flag.

  -y, --yes   skip confirmation prompts for non-destructive operations
  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

Signed-off-by: Spencer Schrock <[email protected]>
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #2918 (ad60980) into main (813e9c6) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2918   +/-   ##
=======================================
  Coverage   52.66%   52.66%           
=======================================
  Files         158      158           
  Lines       12057    12057           
=======================================
  Hits         6350     6350           
  Misses       5337     5337           
  Partials      370      370           

@spencerschrock spencerschrock enabled auto-merge (squash) April 26, 2023 18:33
@spencerschrock spencerschrock temporarily deployed to integration-test April 26, 2023 18:33 — with GitHub Actions Inactive
@spencerschrock spencerschrock merged commit 032f299 into ossf:main Apr 26, 2023
@spencerschrock spencerschrock deleted the fix/cosign-non-interactive branch May 24, 2023 17:08
balteravishay pushed a commit to balteravishay/scorecard that referenced this pull request May 29, 2023
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Avishay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants