-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Return inconclusive result if no fuzzing is detected #1816
Conversation
@@ -86,5 +86,5 @@ func Fuzzing(c *checker.CheckRequest) checker.CheckResult { | |||
"project is fuzzed in OSS-Fuzz") | |||
} | |||
|
|||
return checker.CreateMinScoreResult(CheckFuzzing, "project is not fuzzed") | |||
return checker.CreateInconclusiveResult(CheckFuzzing, "could not determine if project is fuzzed") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make the message explicit - project not fuzzed through any platforms recognizable by Scorecard: oss-fuzz, CFLite. File a support request [here](https://github.com/ossf/scorecard/issues/897) if you would like support for other fuzzing platforms.
. Can even keep this as a failing case instead of inconclusive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to have a generic message File a support request
, I think we should do this in a another PR and for all checks. The details has the details on which platforms are not found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mhh, the details don't have this but it should. Ill update this PR to fix tat too
FWIW I think the fuzzing check is kind of broken at this point because projects integrated into OSS-Fuzz along with CIFuzz/CFLite and actually maintained receive lower scores due to the "unpinned" dependencies and bogus "vulnerabilities" that end up in the OSV database triggering the "vulnerabilities" check. |
Can you explain what the "bogus" OSV entries are? /cc @oliverchang
Can you elaborate on |
I think the latest examples would be https://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2022q1/016161.html and google/oss-fuzz#7434
According to https://oss-fuzz-build-logs.storage.googleapis.com/index.html#ossf-scorecard
for almost two months. |
Stale pull request message |
Return inconclusive result if no fuzzing is detected
No breaking changes