Skip to content

Commit

Permalink
omit vcs info from build (#1514)
Browse files Browse the repository at this point in the history
The detected info is interfering with the manually specified Scorecard
version in the LDFLAGS. While `buildvcs` has been present since Go 1.18,
Go 1.24 changed the behavior again. Our docker image uses Go 1.24 as of
3676bbc.

https://go.dev/doc/go1.24#go-command

Signed-off-by: Spencer Schrock <[email protected]>
  • Loading branch information
spencerschrock authored Feb 20, 2025
1 parent 6a62a1c commit 69ae593
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ LDFLAGS=-X sigs.k8s.io/release-utils/version.gitVersion=v5.1.1 -X sigs.k8s.io/re

build: ## Runs go build on repo
# Run go build and generate scorecard executable
CGO_ENABLED=0 go build -o scorecard-action -trimpath -a -tags netgo -ldflags '$(LDFLAGS)'
CGO_ENABLED=0 go build -o scorecard-action -trimpath -a -tags netgo -buildvcs=false -ldflags '$(LDFLAGS)'

0 comments on commit 69ae593

Please sign in to comment.