Selective opening mode to extract file hash #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you remerge (or whatever git calls it) MASTER? Some of the failures from travis I recognize as fixed, but not entirely sure about the others. |
|
Yes, I'm able to do "git merge binhash" towards master with no problems. I compiled the merged branch with TARGET=server|agent|winagent|local|hybrid, and I haven't got errors. |
|
It looks like the tests are still failing. Perhaps an update didn't make it to your branch? |
|
Try adding to tests/test_os_crypto.c. That should grab the OS_TEXT define and allow some of the tests to pass. |
|
It seems to work now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request #744 solved the issue #42 by opening files in binary mode.
This change leaves the behaviour of Linux binaries unaltered, but makes the file integrity monitoring in Windows to read properly binary files. Unfortunately I discovered that it makes the reception of merged.mg to fail in Windows.
In order to make both elements to work, it's necessary to insert a parameter on every call to file hashing functions. So, OSSEC will only read files in binary mode at Syscheck routines.