Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuffle some variables around #1875

Merged
merged 6 commits into from
Feb 21, 2021
Merged

Shuffle some variables around #1875

merged 6 commits into from
Feb 21, 2021

Conversation

ddpbsd
Copy link
Member

@ddpbsd ddpbsd commented May 23, 2020

Fixes #1871

ddpbsd added 2 commits May 2, 2020 12:54
In issue ossec#1871 @rseichter brings up that gcc 10 switches to '-fno-common'
by default. This killed builds of the agent. Switch agt to os_net_agt in os_net.
Shuffle around the variable in client-agent (I think gcc had issues with agt
being declared in agentd.h which gets included everywhere).
Shuffle around willchroot in manage_agents.
@ddpbsd
Copy link
Member Author

ddpbsd commented May 25, 2020

Updated with a successful server build.
Tested building with mysql, postgresql, and geoip enabled/disabled.

EDIT: SQLite as well.

@ddpbsd
Copy link
Member Author

ddpbsd commented Nov 10, 2020

Updated to current HEAD. Compile tested only.

@lgtm-com
Copy link

lgtm-com bot commented Nov 10, 2020

This pull request fixes 1 alert when merging abfd6d2 into 5928e60 - view on LGTM.com

fixed alerts:

  • 1 for Short global name

@atomicturtle
Copy link
Member

atomicturtle commented Feb 21, 2021

Tested out fine here too (Fedora 33, gcc 10.2.1) , merging this in

@atomicturtle atomicturtle merged commit 1303c78 into ossec:master Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails with GCC-10 and GCC-9 when -fno-common option is used
2 participants