Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a button in the widget to export the data #46

Closed
unkcpz opened this issue Feb 1, 2023 · 2 comments
Closed

Add a button in the widget to export the data #46

unkcpz opened this issue Feb 1, 2023 · 2 comments
Assignees
@dou-du

Comments

@unkcpz
Copy link
Collaborator

unkcpz commented Feb 1, 2023

I think this is mentioned by @giovannipizzi it is better to have a button in the widget where the RAW JSON data can be exported. Although the raw data is the input of the widget, when the widget is shown in the AiiDAlab app, user (especially the developer of the app) loses the chance to easily get the data out and sent it to the developers of this app to easily reproduce and debug.
@dou-du
Copy link
Contributor

dou-du commented Feb 2, 2023

I think this is mentioned by @giovannipizzi it is better to have a button in the widget where the RAW JSON data can be exported. Although the raw data is the input of the widget, when the widget is shown in the AiiDAlab app, user (especially the developer of the app) loses the chance to easily get the data out and sent it to the developers of this app to easily reproduce and debug.

This should be easy to be added. I will do it today.

dou-du added a commit that referenced this issue Feb 8, 2023
@dou-du
Add a button to download bandstructure and DOS Json data (#46) (#47)
d7979b5 
* make it possible to download json files from single bandstructure plot

* make download jsons for both bandstructure and DOS data

* clean example cache

* upgrade pre-commit package to fix the fail of the workflow

* change back pre-commit version to v2.11.1

* fix the pre-commit error by using isort v5.12.0

* fix the pre-commit error by upgrading pre-commit v3.0.4

* install isort firstly

* fix the pre-commit error by changing pre-commit-config file
@unkcpz
Copy link
Collaborator Author

unkcpz commented Feb 17, 2023

Closed by #47

@unkcpz unkcpz closed this as completed Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dou-du dou-du

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@unkcpz @dou-du