chore(DependencyGraphNavigator): Avoid relying on manager name prefixes #9776
+19
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9776 +/- ##
=========================================
Coverage 68.07% 68.07%
Complexity 1284 1284
=========================================
Files 249 249
Lines 8827 8827
Branches 918 918
=========================================
Hits 6009 6009
Misses 2432 2432
Partials 386 386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sschuberth
force-pushed
the
dep-graph-check
branch
from
1116fd7 to
0cf2ac7
Compare
sschuberth
changed the title
sschuberth
force-pushed
the
dep-graph-check
branch
from
0cf2ac7 to
ed5d226
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sschuberth
force-pushed
the
dep-graph-check
branch
from
ed5d226 to
62fcc42
Compare
fviernau
requested changes
Jan 18, 2025
| // TODO: Relax this assumption that package manager names start with the name of the type of project | ||
| // they manage, for example that "GradleInspector" manages "Gradle" projects. | ||
| val managers = graphs.keys.filter { it.startsWith(project.id.type) } | ||
| // Collect all root indices for all manager whose graphs have projects of the respective type. |
This removes the assumption that package manager names start with the name of the type of project they manage in favor of collecting all root indices that match the project and ensuring that they only stem from a single manager. Signed-off-by: Sebastian Schuberth <[email protected]>
…bled This fails early additionally to the check the `DependencyGraphNavigator` does in `directDependencies()`. The latter check is still and anyway required to unambiguously get the direct dependencies for a project unless the API is changed. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
dep-graph-check
branch
from
62fcc42 to
2273808
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the assumption that package manager names start with the name of the type of project they manage in favor of collecting all root indices that match the project and ensuring that they only stem from a single manager.