deps(reporter-web-app): Update React packages #6598
Conversation
Which means this PR should only be merged after #6552, correct? |
Yes. We were hoping to have these in parallel but they depend on each other. |
React related pages that are updated are "react","react-app-polyfill", "react-dom","react-redux","react-scripts","react-syntax-highlighter" and "@testing-library/react". The only packages that needed changes in the code are "react", "react-dom" and "react-scripts". In the "react-dom" V18.2.0 the rendering of the app differs than "react-dom" V17.0.2 so This what required to change the code in index.js . Also "react-dom" requires "react" package to be up to date. Fix the commenting style of the first line in index.css as "react-scripts" had a problem with it because of CSS minification. Signed-off-by: Menatalla Elnemr <[email protected]>
mennaElnemr9
force-pushed
the
react-updates
branch
from
c1d1c50 to
edd98fd
Compare
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| version "17.0.2" | ||
| resolved "https://registry.yarnpkg.com/react/-/react-17.0.2.tgz#d0b5cc516d29eb3eee383f75b62864cfb6800037" | ||
| integrity sha512-gnhPt75i/dq/z3/6q/0asP78D0u592D5L1pd7M8P+dck6Fu/jJeL6iVVK23fptSUZj8Vjf++7wXA8UNclGQcbA== | ||
| react@^18.2.0: |
There was a problem hiding this comment.
Medium Vulnerability:
npm : -/react : 18.2.0
0 Critical, 0 High, 1 Medium, 0 Low vulnerabilities have been found across 1 dependencies.
View the Lift console for details about these vulnerabilities.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
There was a problem hiding this comment.
Marking this pull request as on-hold as it soon be superseded my code changes on the webapp-reporter-v0.3 branch.
|
@mennaElnemr9 I am closing your pull request in favor of #7952. |
React packages updates rely on antd package update so without updating antd package along with react packages some errors will pop in the terminal that are in the antd packages scripts telling that some links in the antd are not supported anymore
please refer to the screenshot:
keeping in mind that antd updates change in the UI .
Please ensure that your pull request adheres to our contribution guidelines. Thank you!