Switch to the Semver4j fork #6154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sschuberth
force-pushed
the
semver4j-fork
branch
3 times, most recently
from
ee57875 to
404ac51
Compare
sschuberth
force-pushed
the
semver4j-fork
branch
2 times, most recently
from
96a4f67 to
ca6f534
Compare
sschuberth
force-pushed
the
semver4j-fork
branch
3 times, most recently
from
be394c2 to
f86ceb9
Compare
sschuberth
force-pushed
the
semver4j-fork
branch
2 times, most recently
from
0f61618 to
cff197b
Compare
The new semver4j GitHub organization contains a maintained fork / copy [1] of the original semver4j library by @vdurmont [2]. However, the API changed quite significantly. Catch up with those changes in order to (partly) fix issue #6153. [1]: https://github.com/semver4j/semver4j [2]: https://github.com/vdurmont/semver4j Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
semver4j-fork
branch
from
cff197b to
7a9d800
Compare
Comment on lines
-123
to
+125
| it == CommandLineTool.ANY_VERSION || it.isSatisfiedBy(actualVersion) | ||
| Semver.coerce(actualVersion).satisfies(it) |
There was a problem hiding this comment.
Why is the check for ANY_VERSION dropped?
There was a problem hiding this comment.
ANY_VERSION was introduced here in d8c65c3 to work around a limitation of the original isSatisfiedBy() call which does not handle non-semantic versions, but even those should be accepted here. This is not necessary anymore with the new code as it uses coerce() before.
| // '1.0' does not satisfy the version range [1.0,2.0], see | ||
| // https://github.com/vdurmont/semver4j/issues/67. | ||
| Requirement.buildIvy(id.version).isSatisfiedBy(Semver(pkgId.version, Semver.SemverType.LOOSE)) | ||
| Semver.coerce(pkgId.version).satisfies(id.version) |
There was a problem hiding this comment.
satisfies(String) never uses coerce internally.
Isn't this required to solve the TODO above?
There was a problem hiding this comment.
It shouldn't be necessary (anymore), see semver4j/semver4j#100. And I just manually verified that Semver.coerce("1.0").satisfies("[1.0,2.0]") == true.
MarcelBochtler
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.