downloader: Migrate from JSch to MINA as the SSH backend for JGit #6030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The used `org.eclipse.jgit.ssh.apache.agent` artifact has build-in ssh-agent support. As of 43ff39e there should have been no need anymore to avoid "keyboard-interactive" prompts as the `CredentialsProvider` is explicit set to ORT's own `AuthenticatorCredentialsProvider` only. Resolves #6029. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
jsch-to-mina
branch
from
ca40652 to
e9a8c59
Compare
Codecov ReportBase: 57.79% // Head: 58.06% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6030 +/- ##
============================================
+ Coverage 57.79% 58.06% +0.27%
Complexity 2013 2013
============================================
Files 324 324
Lines 18761 18692 -69
Branches 3876 3851 -25
============================================
+ Hits 10842 10853 +11
+ Misses 6862 6778 -84
- Partials 1057 1061 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
MarcelBochtler
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The used
org.eclipse.jgit.ssh.apache.agentartifact has build-inssh-agent support. As of 43ff39e there should have been no need anymore
to avoid "keyboard-interactive" prompts as the
CredentialsProviderisexplicit set to ORT's own
AuthenticatorCredentialsProvideronly.Resolves #6029.
Signed-off-by: Sebastian Schuberth [email protected]