-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ADOPTERS.md #5409
Add ADOPTERS.md #5409
Conversation
44119c7
to
479ada2
Compare
Codecov Report
@@ Coverage Diff @@
## main #5409 +/- ##
============================================
+ Coverage 72.12% 72.16% +0.04%
- Complexity 1984 1990 +6
============================================
Files 264 264
Lines 13989 13986 -3
Branches 1994 2002 +8
============================================
+ Hits 10089 10093 +4
+ Misses 2835 2823 -12
- Partials 1065 1070 +5
Continue to review full report at Codecov.
|
ADOPTERS.md
Outdated
@@ -0,0 +1,9 @@ | |||
# Adopters | |||
|
|||
_If you're using ORT in your organization, please add your organization's name to the table below. This really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to say: please add your organization's name to the bottom of the table below? So that the ordering is defined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would prefer alphabetical sorting, to not imply that the order has any meaning. Also I don't like that the list is not sorted at all in the linked example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @mnonnenmacher. So, @tsteenbe let's mention the ordering in the comment then?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mnonnenmacher @fviernau Changed the comment to say "to the alphabetically sorted table below."
Inspired by [1]. [1]: https://github.com/backstage/backstage/blob/e487242d70e52aa7b6a48266a09caebbcc433080/ADOPTERS.md Signed-off-by: Thomas Steenbergen <[email protected]>
479ada2
to
7b40fdf
Compare
Inspired by 1.