Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADOPTERS.md #5409

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Add ADOPTERS.md #5409

merged 1 commit into from
Jun 7, 2022

Conversation

tsteenbe
Copy link
Member

@tsteenbe tsteenbe commented Jun 2, 2022

Inspired by 1.

@tsteenbe tsteenbe requested a review from a team as a code owner June 2, 2022 08:13
@tsteenbe tsteenbe force-pushed the add-adopters-file branch from 44119c7 to 479ada2 Compare June 2, 2022 08:15
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #5409 (7b40fdf) into main (bdf48a9) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #5409      +/-   ##
============================================
+ Coverage     72.12%   72.16%   +0.04%     
- Complexity     1984     1990       +6     
============================================
  Files           264      264              
  Lines         13989    13986       -3     
  Branches       1994     2002       +8     
============================================
+ Hits          10089    10093       +4     
+ Misses         2835     2823      -12     
- Partials       1065     1070       +5     
Impacted Files Coverage Δ
downloader/src/main/kotlin/vcs/Git.kt 68.80% <0.00%> (-2.14%) ⬇️
...rc/main/kotlin/experimental/ExperimentalScanner.kt 53.46% <0.00%> (-0.38%) ⬇️
...main/kotlin/managers/utils/SpdxResolvedDocument.kt 94.06% <0.00%> (-0.29%) ⬇️
downloader/src/main/kotlin/vcs/Cvs.kt 17.72% <0.00%> (ø)
...zer/src/main/kotlin/managers/utils/MavenSupport.kt 78.34% <0.00%> (+0.05%) ⬆️
scanner/src/main/kotlin/scanners/fossid/FossId.kt 73.95% <0.00%> (+1.22%) ⬆️
...ner/src/main/kotlin/experimental/ScanController.kt 72.41% <0.00%> (+1.90%) ⬆️
analyzer/src/main/kotlin/managers/Conan.kt 79.23% <0.00%> (+2.51%) ⬆️
downloader/src/main/kotlin/vcs/Subversion.kt 72.05% <0.00%> (+3.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdf48a9...7b40fdf. Read the comment docs.

fviernau
fviernau previously approved these changes Jun 3, 2022
ADOPTERS.md Outdated
@@ -0,0 +1,9 @@
# Adopters

_If you're using ORT in your organization, please add your organization's name to the table below. This really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact._
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to say: please add your organization's name to the bottom of the table below? So that the ordering is defined?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would prefer alphabetical sorting, to not imply that the order has any meaning. Also I don't like that the list is not sorted at all in the linked example.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @mnonnenmacher. So, @tsteenbe let's mention the ordering in the comment then?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mnonnenmacher @fviernau Changed the comment to say "to the alphabetically sorted table below."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants