github-workflows: Run functional tests in Docker via Batect #5031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschuberth
force-pushed
the
gh-funtest-docker
branch
from
841c54c to
fd63a84
Compare
tsteenbe
reviewed
Feb 10, 2022
| - name: Setup Java | ||
| uses: actions/setup-java@v2 | ||
| with: | ||
| distribution: adopt |
There was a problem hiding this comment.
Why did you use 'adopt' e.g. Adopt OpenJDK Hotspot here and not 'temurin' e.g. Eclipse Temurin. Though AdoptOpenJDK is superseded by Temurin or is my understanding wrong? https://adoptopenjdk.net/ links to https://adoptium.net/?variant=openjdk11
There was a problem hiding this comment.
I'm for now aligning with https://github.com/oss-review-toolkit/ort/blob/master/Dockerfile#L31, but please note this is a draft still anyway. I probably can replace "adoptopenjdk" with "eclipse-temurin" later on.
sschuberth
force-pushed
the
gh-funtest-docker
branch
9 times, most recently
from
d4bbbda to
8285f29
Compare
sschuberth
force-pushed
the
gh-funtest-docker
branch
from
8285f29 to
fd990f2
Compare
sschuberth
force-pushed
the
gh-funtest-docker
branch
5 times, most recently
from
2edd8b2 to
d7c10ff
Compare
Signed-off-by: Sebastian Schuberth <[email protected]>
This works around `beforeSpec` being executed even if the tests are not matched by a tag, see [1]. [1]: kotest/kotest#1516 (comment) Signed-off-by: Sebastian Schuberth <[email protected]>
This way Gradle's console mode can be overriden e.g. when running Batect from within a GitHub workflow. Signed-off-by: Sebastian Schuberth <[email protected]>
This avoids to set up required tools in the GitHub workflow itself, and tests building the `Dockerfile` at the same time. There is currently a single test in `PubFunTest` which fails in Docker for unclear reasons. Postpone fixing the issue until later by not running this single test inside of Docker, but instead outside of Docker. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
gh-funtest-docker
branch
from
c8db8d7 to
2f3fa5e
Compare
Azure pipelines stopped working due to a lack of parallel builds. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
gh-funtest-docker
branch
from
2f3fa5e to
9ab14d5
Compare
This is to work around [1]. [1]: aboutcode-org/scancode-toolkit#2869 Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
gh-funtest-docker
branch
from
71cfd2d to
b28bf9e
Compare
mnonnenmacher
requested changes
Feb 16, 2022
mnonnenmacher
approved these changes
Feb 16, 2022
This was referenced Feb 16, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Schuberth [email protected]