Add grouping functionality to the rule violation table #5012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
tsteenbe
added a commit
that referenced
this pull request
Feb 2, 2022
ESLint is already run as part of ORT's build and Lift is returning tens of false-positives in pull requests see for example [1]. [1]: #5012 Signed-off-by: Thomas Steenbergen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since one package can contain multiple rule violations the table gets
easily messy. The grouping functionality helps to keep it clean with
summarising all violations of one rule into a sub table. Due to the fact
that both tables need the same columns and collapsible, both is moved
to Shared.js and into a new component named RuleViolationCollapsable.js.
Signed-off-by: Lenny Rook [email protected]