-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More saxon curations #263
More saxon curations #263
Conversation
69228f2
to
0cebfed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understand why you would extract base properties for Saxon but the id/comment combination is incorrect as https://repo1.maven.org/maven2/net/sf/saxon/saxon/8.7/saxon-8.7.pom does include SCM tag. Recommend to update the comment to use Maven Central pom location but mention SCM url does not work anymore.
0cebfed
to
9d8426a
Compare
9d8426a
to
89f9489
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like to request 2 more changes:
- Drop the
comment
for id:Maven:net.sf.saxon:saxon:9
curation it mentionsthe POM in vcs revision curation - makes no sense to me. - Improve the
comment
forMaven:net.sf.saxon:saxon
curation to include POM links for 8.7 and 9 to as proof of correctness of curation.
Maybe change from:
- id: "Maven:net.sf.saxon:saxon"
curations:
comment: |-
The POMs for the different versions either have no or an outdated SCM tag.
to
- id: "Maven:net.sf.saxon:saxon"
curations:
comment: |-
The POMs for the different versions either have no or an outdated SCM tag.
See https://repo1.maven.org/maven2/net/sf/saxon/saxon/8.7/ and
https://nexus.intranda.com/repository/maven-releases/net/sf/saxon/saxon/9/saxon-9.pom.
Why not? If the POM contained an
There are more version that those, and I don't think it makes sense to add each of them as a proof. So I'll pick just one as an example. |
Ok, I now get your point: You're arguing that now with the https://nexus.intranda.com/repository/maven-releases/net/sf/saxon/saxon/9/saxon-9.pom link being part of the more generic curation, it does not need to be repeated in the version-specific curation. I agree to that. |
…ions Signed-off-by: Sebastian Schuberth <[email protected]>
89f9489
to
ec305bc
Compare
Signed-off-by: Sebastian Schuberth <[email protected]>
Signed-off-by: Sebastian Schuberth <[email protected]>
ec305bc
to
178d46a
Compare
No description provided.