Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #350 #375

Merged
merged 3 commits into from
Oct 19, 2021
Merged

Fix issue #350 #375

merged 3 commits into from
Oct 19, 2021

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Oct 6, 2021

Fix issue #350.

How to test it?

Run the following command:

roslaunch vrx_gazebo gymkhana.launch extra_gazebo_args:="--verbose"

You should see just one instance of each debug message.

Signed-off-by: Carlos Agüero <[email protected]>
@caguero caguero requested a review from j-herman October 12, 2021 16:19
@j-herman
Copy link
Collaborator

I ran the task, validated that scoring still works the same as before, and am seeing only one instance of the "OnReady", "Publishing Goal coordinates", and "OnRunning" messages. The "Vehicle released" message is no longer appearing at all - is that intentional? If so, this is good to merge.

@caguero
Copy link
Contributor Author

caguero commented Oct 18, 2021

I ran the task, validated that scoring still works the same as before, and am seeing only one instance of the "OnReady", "Publishing Goal coordinates", and "OnRunning" messages. The "Vehicle released" message is no longer appearing at all - is that intentional? If so, this is good to merge.

Thanks! That's expected because the plugins that lock the vehicle are silenced. I think this is OK.

@caguero caguero merged commit 943ac4f into master Oct 19, 2021
@caguero caguero deleted the caguero/issue_350 branch January 5, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants