-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model submission for Marmotte (HD2) sensor configurations 1,2 by CTU-CRAS-Norlab #842
Model submission for Marmotte (HD2) sensor configurations 1,2 by CTU-CRAS-Norlab #842
Conversation
I downgraded model.sdf to SDF version 1.6 as requested for all our models. This model used no 1.7 features, so just changing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The initial assessment of the the model is complete however there are some issues to resolve before this model can be merged and utilized in a competitive setting:
- Please adjust the minimum distance clipping range on the D435 and Basler cameras to align with the standard clip range in the SubT repository.
- Please adjust the Omnicamera sensor to align with the versions accepted on the Spot and MARV platforms.
- Please add intrinsic values for all Basler cameras.
- Please adjust LIDAR parameters following the in-line comments to match the standard for LIDAR sensors in the SubT repository.
- The texture and color of the sensor payload on the vehicle almost looks like stone. Is this intended?
Please address the issues noted above in this pull request. Once the above issues are fixed, your submission will move onto the next review stage!
submitted_models/ctu_cras_norlab_marmotte_sensor_config_1/model.config
Outdated
Show resolved
Hide resolved
submitted_models/ctu_cras_norlab_marmotte_sensor_config_1/model.sdf
Outdated
Show resolved
Hide resolved
submitted_models/ctu_cras_norlab_marmotte_sensor_config_1/model.sdf
Outdated
Show resolved
Hide resolved
This is an example of the rendering bug which forced us to increase clipping distance to 0.4. Notice the (dis)appearing tracks in cameras based on the world orientation of the robot. marmotte_cam_problem.mp4 |
I've solved some of the mentioned issues.
I also added an RViz config for easy visual inspection of the sensor data. |
I also moved battery plugin to the last place, following #901 (not sure if it's needed here, but it shouldn't hurt). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for the clarification and changes.
This is our sensor configuration of SuperDroid HD2 tracked robot. It is the same base platform as already existing
MARBLE_HD2
robot.