Remove Python 2 support #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
commented
Jun 30, 2020
|
@wjwwood Friendly ping here for review. |
|
This is on me, because I need to do a final release with python support and then do a release that is python3 only without breaking older platforms and the pip install for python2. I messed this up for catkin tools and I just need to sit for a day or so and do it properly with test releases and stuff. |
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
|
Oooook, I think we've got our last Python2 release out and working in
|
|
CI looks good (Windows warning is not related, it's in |
Signed-off-by: William Woodall <[email protected]>
Signed-off-by: William Woodall <[email protected]>
Signed-off-by: William Woodall <[email protected]>
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed over in #66 (comment) , we should remove support for Python 2 from this package. This PR does this by doing 3 different things:
There is more work that can be done here; the indirection that was in place to support both Python 2 and Python 3 is probably no longer required. But I think this is a good first step, and we can always clean some of that stuff up later.