Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add matrix_mode: False option to sim params yaml to allow vectorized batch params #158

Merged
merged 1 commit into from
Aug 30, 2023
Merged

add matrix_mode: False option to sim params yaml to allow vectorized batch params #158

merged 1 commit into from
Aug 30, 2023

Conversation

andermi
Copy link
Collaborator

@andermi andermi commented Aug 28, 2023

matrix_mode: False for vectorized batch params instead of meshgrid

@andermi andermi requested a review from hamilton8415 August 28, 2023 17:49
@andermi andermi mentioned this pull request Aug 28, 2023
Merged
hamilton8415
hamilton8415 approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@hamilton8415 hamilton8415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this but it seems we should move forward with getting these merged into to main and we can then test them all together. I see tests are failing, possibly because of the versioning issue with FreeSurfaceHydrodynamics.

@andermi
Copy link
Collaborator Author

andermi commented Aug 30, 2023

I set a few of these PR's to merge into other branches to make diffs easier to look through. This one won't go to main, so no worries!

@hamilton8415
Copy link
Collaborator

Yes, I'm catching up with the roadmap!

@andermi andermi merged commit 308dd8c into andermi/fix_fshydro_includes Aug 30, 2023
@andermi andermi deleted the andermi/add_vectorized_batch_mode branch August 30, 2023 23:20
@andermi andermi linked an issue Sep 11, 2023 that may be closed by this pull request
Add vector mode for batch running simulations #155
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamilton8415 hamilton8415 hamilton8415 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add vector mode for batch running simulations
2 participants
@andermi @hamilton8415