Complete ign to gz migration #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aha! They are failing on |
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
hidmic
force-pushed
the
hidmic/ign-to-gz
branch
from
2c9a5dc to
ff5908e
Compare
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
|
@caguero This is getting hairy. Tests that use the LRAUV controller fail seemingly at random, or at least I cannot see the pattern just yet. |
Protobuf relies a lot on globals for message registration. Non-POD types in global storage are a recipe for disaster, specially when loading and unloading libraries. This change fixed double free crashes upon MBARI's LRAUV controller exit. Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
|
Finally passing. @adityapande-1995 @arjo129 PTAL! |
| && curl -s https://raw.githubusercontent.com/ros/rosdistro/master/ros.asc | sudo apt-key add - \ | ||
| && sudo apt-get update \ | ||
| && sudo apt-get install -y python3-vcstool python3-colcon-common-extensions | ||
| # Install Ignition build tools |
There was a problem hiding this comment.
Minor comment : Ignition -> Gazebo
adityapande-1995
approved these changes
Sep 26, 2022
| curl \ | ||
| gdb \ |
There was a problem hiding this comment.
Nit : Do we need gdb, and libbluetooth for the docker ?
There was a problem hiding this comment.
Ahh, my mistake. I'll open up a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precisely what the title says. Not ready yet, as mission tests against latest
lrauv-applicationare failing -.-