Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portuguese Ledge world #172

Merged
merged 11 commits into from
Apr 14, 2022
Merged

Portuguese Ledge world #172

merged 11 commits into from
Apr 14, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Mar 15, 2022

Builds on top of

Closes

Requires

Model on Fuel:

Preview using Ogre1

pt_ledge

Update

Loading 18 tiles (not on Fuel yet) using Ogre 2

18_tiles

Update

Using levels: ign gazebo portuguese_ledge.sdf --levels

tile_levels_2

TODO

  • Verify / fix
    • dimensions
    • lat / lon position
  • Break into smaller files
    • Be sure to fill no data values for all files
    • Each file should be a square, to avoid the min-elevation padding cliff
  • Use levels
  • Support on Ogre 2
  • Use Fuel URLs
  • Check collision positions
  • Use better textures?
  • Check seams

Known issues

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina mentioned this pull request Mar 16, 2022
39 tasks
@chapulina chapulina self-assigned this Mar 23, 2022
@chapulina chapulina changed the base branch from main to chapulina/world_spherical March 23, 2022 22:20
Signed-off-by: Louise Poubel <[email protected]>
Base automatically changed from chapulina/world_spherical to main March 30, 2022 19:38
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina marked this pull request as ready for review March 30, 2022 22:50
Signed-off-by: Louise Poubel <[email protected]>
@caguero caguero requested a review from hidmic April 6, 2022 16:27
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to test it next, but it looks good.

lrauv_ignition_plugins/worlds/portuguese_ledge.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
lrauv_ignition_plugins/worlds/portuguese_ledge.py Outdated Show resolved Hide resolved
lrauv_ignition_plugins/worlds/portuguese_ledge.py Outdated Show resolved Hide resolved
lrauv_ignition_plugins/worlds/portuguese_ledge.sdf.em Outdated Show resolved Hide resolved
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

Thanks for the review, @hidmic , I've addressed all your comments in 9a11eee.

Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chapulina when trying to run this locally, I get:

ERROR 1: An error occurred while creating a virtual connection to the DAP server:Error while reading the URL: https://fuel.ignitionrobotics.org/1.0/OpenRobotics/models/Portuguese Ledge/tip/files/meshes/PortugueseLedgeTile15_DecDeg.nc.ver.
The OPeNDAP server returned the following message:
Bad Request:
[GUI] [Err] [Dem.cc:113] Unable to open DEM file[https://fuel.ignitionrobotics.org/1.0/OpenRobotics/models/Portuguese Ledge/tip/files/meshes/PortugueseLedgeTile15_DecDeg.nc]. Format not recognized as a supported dataset.
[GUI] [Err] [SceneManager.cc:720] Failed to load heightmap dem data from [https://fuel.ignitionrobotics.org/1.0/OpenRobotics/models/Portuguese Ledge/tip/files/meshes/PortugueseLedgeTile15_DecDeg.nc]
[GUI] [Err] [SceneManager.cc:395] Failed to load geometry for visual: visual

Am I missing something? I'm at Ignition's bleeding edge, built Garden from source today.

docker/empty_world/Dockerfile Show resolved Hide resolved
lrauv_ignition_plugins/worlds/empy_expander.py Outdated Show resolved Hide resolved
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

Am I missing something? I'm at Ignition's bleeding edge, built Garden from source today.

Ah sorry, I forgot we needed a forward port, this should be it:

The specific PR we need is:

@chapulina chapulina merged commit ad474de into main Apr 14, 2022
@chapulina chapulina deleted the chapulina/dem branch April 14, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants