Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add water surface at Z = 0 #38

Closed
chapulina opened this issue Sep 24, 2021 · 3 comments
Closed

Add water surface at Z = 0 #38

chapulina opened this issue Sep 24, 2021 · 3 comments
Assignees
@arjo129

Comments

@chapulina
Copy link
Contributor

chapulina commented Sep 24, 2021 •
edited
Loading

On https://github.com/osrf/lrauv_private/pull/101 the water surface was placed at Z = 0.5 m so that the vehicle doesn't go into a roll. This currently only affects buoyancy. We should fix the underlying issue and move he surface to 0.0.
@arjo129
Copy link
Member

arjo129 commented Sep 27, 2021

The CI is an X, for a good reason too. The behavior near the surface is a bit odd (this is expected given the changes in the way we calculate the torque). Should we revert the commit till a fix is found?

@chapulina
Copy link
Contributor Author

chapulina commented Sep 27, 2021 •
edited
Loading

Ouch I missed the ❌ See https://github.com/osrf/lrauv_private/pull/105

@chapulina chapulina changed the title Move water surface to Z = 0 Add water surface at Z = 0 Sep 27, 2021
@chapulina chapulina transferred this issue from another repository Nov 2, 2021
@chapulina chapulina mentioned this issue Nov 12, 2021
Closed
@arjo129 arjo129 self-assigned this Jan 13, 2022
@arjo129 arjo129 mentioned this issue Jan 24, 2022
Closed
arjo129 added a commit that referenced this issue Jan 24, 2022
@arjo129
Adds a surface to the SDFormat files.
40d04fa 
This should address #38.  It requires the following upstream fixes and relevant forward ports:

* gazebosim/gz-sim#1297
* gazebosim/gz-sim#1298

⚠️ Do not merge till the CI goes from ❌ to :heavy_checkmark:

Signed-off-by: Arjo Chakravarty <[email protected]>
@arjo129 arjo129 mentioned this issue Jan 24, 2022
Closed
@arjo129 arjo129 linked a pull request Jan 24, 2022 that will close this issue
Adds a surface to the SDFormat files. #153
Closed
@arjo129
Copy link
Member

arjo129 commented Mar 7, 2022

Closed by #161 & #162

@arjo129 arjo129 closed this as completed Mar 7, 2022
@hidmic hidmic mentioned this issue Aug 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arjo129 arjo129

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds a surface to the SDFormat files. osrf/lrauv
2 participants
@arjo129 @chapulina