Original from bitbucket #2
Conversation
There was a problem hiding this comment.
Just some high-level comments for the initial port.
I checked that:
- The package builds with
colcon buildagainstbuoy_msgs - I can run
ros2 run buoy_examples torque_controllerros2 launch buoy_examples torque_controller.launch.py(with my suggested change topbcontrol)
I can't run either of:
ros2 launch buoy_examples gain_scheduler.launch.pyros2 run buoy_examples gain_scheduler_node.py
That's why I asked if we could move that script.
| @@ -0,0 +1,75 @@ | |||
| #!/usr/bin/python | |||
There was a problem hiding this comment.
Can this file be moved to buoy_examples or does it need to be in scripts?
There was a problem hiding this comment.
@hamilton8415 and I have been pondering if the gain scheduler really serves as a good example or if we should just leave it in our internal repo.
If we do leave it here and test it on the buoy (should be tested soon), I just remembered I should make some rosdeps and/or a requirements.txt for it (there are a few python packages that are needed).
There was a problem hiding this comment.
Got it. I'll leave it up to you if you want to add that as part of this PR or in a follow up.
Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
| @@ -0,0 +1,75 @@ | |||
| #!/usr/bin/python | |||
There was a problem hiding this comment.
Got it. I'll leave it up to you if you want to add that as part of this PR or in a follow up.
|
@chapulina , I fixed cpp lint for our files, but I don't think I can exclude JustInterp.hpp ... there is an open ticket to do so, though. Any ideas? Should I fix cpp lint for JustInterp.hpp? |
Yeah it's inconvenient not to have a quick way of excluding a file from all linters. On #6 I excluded it from cpplint and uncrustify with linter-specific markers. |
This is the version of torque controller tested on the buoy. See #1 for updated design.
Need to do readme and test the python gain scheduler...