CHANGELOG 5.8.1 #7957
Merged
CHANGELOG 5.8.1 #7957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwass
requested changes
Mar 20, 2023
| ### Documentation | ||
|
|
||
| - Add note about windows_security_products compatibility ([#7880](https://github.com/osquery/osquery/pull/7880)) | ||
| - CHANGELOG 5.7.0 ([#7894](https://github.com/osquery/osquery/pull/7894)) |
There was a problem hiding this comment.
Suggested change
| - CHANGELOG 5.7.0 ([#7894](https://github.com/osquery/osquery/pull/7894)) |
There was a problem hiding this comment.
Eh? Why remove this?
There was a problem hiding this comment.
I don't see any reason why a user would benefit from seeing that the changelog was updated for 5.7 in the 5.8.1 release notes. I don't see much harm either though so if you want to leave it there that's fine with me.
There was a problem hiding this comment.
I agree it's of low value, but I believe in being complete about them. I've generally tended to including all changes.
Thank you for the suggestions. I think we probably need better hygiene on PR titles Co-authored-by: Zach Wasserman <[email protected]>
zwass
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.