Fix assert fail for unverified WMI request result #7921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
directionless
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
Talking to @Smjert this problem may effect other places. But this code is reasonable and we should merge it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In debug mode an osquery::Expected class object will asserted in destructor, if it's not checked for results.
When we check multiple osquery::Expected objects in single if, in case of first one has error, the second one will not be checked and osquery::Expected object destructor will assert.
So, every osquery::Expected must be checked explicitly