Add support of parsing authorized_keys file
#7560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iko1
changed the title
iko1
force-pushed
the
fix/authorized-keys-table
branch
from
8f11a87 to
4200e4b
Compare
|
Can you explain what this changes or adds to the existing |
mike-myers-tob
added
ready for review
iko1
force-pushed
the
fix/authorized-keys-table
branch
from
bf5c07a to
39a9f52
Compare
|
@directionless is going to resolve conversations above and re-review/approve, but this is slipping to 5.5 milestone |
mike-myers-tob
changed the title
authorized_keys file
Would someone else like to take a look at this PR? |
directionless
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the authorized_keys table is populated with an empty column: "algorithm" and other key fields are added to the column "key" alongside the actual key.
I've taken a look at the file format to populate the table correctly:
The file format consists of keys on each line for public-key authentication, and the format is quite simple, unless few exceptions: line starts with '#' or the option zos-key-ring-label is specified.
The line syntax : (options) key-type base64-encoded key (comment)
Options field (optional) are comma-delimited. There are pre-set of options that can be specified. Spaces are not allowed unless within double quotes for example in the Option Command.
Key type field(required) is one of the following options "ssh-dss", "ssh-rsa", "ecdsa-sha2-nistp256", "ecdsa-sha2- nistp384", or "ecdsa-sha2-nistp521" the code consists that one of key type exists to parse the line when key type is unknown, the line is ignored.
Key field(required): base64-encoded key
Comment(optional): it's mainly used to recognize the key origin.
I've refactored the table schema according to the fields above, the parser code, and written some unit tests to check the code with some generic public-key definitions that I've found on the web.
Fixes #7544