tests: Reduce flakiness of test_osqueryi #6688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for looking into this! I had a quick look but the part that doesn't convince me is adding more |
|
I agree, can do. I am pretty optimistic about the other changes in this PR. I will update and remove the decorators momentarily. |
|
(just running the tests again) |
mike-myers-tob
added
the
flaky test
aikuchin
pushed a commit
to aikuchin/osquery
that referenced
this pull request
Jul 11, 2023
…1 to master * commit 'dc2c7d0ef21f7913448c664ae0ebddd034afc977': (43 commits) Changelog 4.5.1 (osquery#6692) Fix incorrect stat return checking within process_events (osquery#6694) tests: Reduce flakiness of test_osqueryi (osquery#6688) Flush stdout with --help (osquery#6693) Enable cppcheck target in macOS builds (osquery#6685) Fix dirPathsAreEqual the documented way (osquery#6690) Add broad exception catching for table execution (osquery#6689) Authenticode table with catalog file info (osquery#6677) Document max interval for scheduled queries (osquery#6683) Fix container overflow in curl_certificate (osquery#6664) Update documentation around build steps (osquery#6681) Incorporate suggested changes on PR 5789 from Directionless Copy-edit and Markdown lint the remaining deployment docs Copy-edit and Markdown lint, clarify section headers for HTTP API doc Copy-edit and Markdown lint, remove old comment about CI Copy-edit and Markdown lint many deployment docs Fixed handling of invalid array bound error with EvtNext function (osquery#6660) Copy-edit and Markdown lint (just nits) remaining developer docs Copy-edit and Markdown lint (just nits) several developer docs Copy-edit and Markdown lint the configuration plugin guidance; minor clarification ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to reduce the flakiness of
test_osqueryiby reducing the complexity of flag usage. It also adds the 'default flags' toTimeoutRunner, preventing local state from impacting the tests.