-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tables: Add constraints and testing #6105
Merged
theopolis
merged 22 commits into
osquery:master
from
directionless:seph/table-constraint
Dec 13, 2019
Merged
tables: Add constraints and testing #6105
theopolis
merged 22 commits into
osquery:master
from
directionless:seph/table-constraint
Dec 13, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directionless
force-pushed
the
seph/table-constraint
branch
from
December 7, 2019 04:31
2b0ae46
to
ab351c2
Compare
theopolis
requested changes
Dec 10, 2019
theopolis
force-pushed
the
seph/table-constraint
branch
from
December 11, 2019 03:24
411dd2c
to
e6eb99a
Compare
|
theopolis
force-pushed
the
seph/table-constraint
branch
2 times, most recently
from
December 12, 2019 00:54
a9b75cb
to
ff155b7
Compare
it's an index on osx, but not on windows
This reverts commit ee0d19c.
theopolis
force-pushed
the
seph/table-constraint
branch
from
December 12, 2019 04:26
ff155b7
to
8f580cd
Compare
theopolis
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #6103 I thought I'd take a pass at the spec files and tests. Not totally sure on all of these.
Also adds an
IntOrEmpty
type to the validation mapRequires: #6104
Relates To: #5932