Remove support for SingleVariable objective #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This structure of objective is not exploited by OSQP, it is handled the same way as a `ScalarQuadraticFunction`. Objective bridges can no transform it automatically so solvers should not support it.
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
+ Coverage 87.55% 88.04% +0.48%
==========================================
Files 6 6
Lines 932 920 -12
==========================================
- Hits 816 810 -6
+ Misses 116 110 -6
Continue to review full report at Codecov.
|
|
Looks good to me. So bridges are fully ready for prime time now? That'll be wonderful. |
|
@tkoolen Yes, we now have variable, constraint and objective bridges working together since MOI v0.9.2, I don't see any infrastructure change to make in the near future. One important addition though is jump-dev/MathOptInterface.jl#680 which is useful when developing bridges and for helping the user understand what happens under the hood. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This structure of objective is not exploited by OSQP, it is handled the
same way as a
ScalarQuadraticFunction. Objective bridges can notransform it automatically so solvers should not support it.
Support for
ScalarAffineFunctionshould also be removed for the same reason but there is currently no objective bridge for transformingScalarAffineFunctionintoScalarQuadraticFunction.