Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to BinaryBuilder + drop support for 0.7 #52

Merged
merged 6 commits into from
May 24, 2019
Merged

Conversation

bstellato
Copy link
Collaborator

@bstellato bstellato commented May 23, 2019

Fixes #44
Fixes #51

Replaces #49

@bstellato bstellato requested a review from blegat May 23, 2019 22:22
@bstellato
Copy link
Collaborator Author

I am getting the error

Got exception outside of a @test MathOptInterface.UnsupportedAttribute{MathOptInterface.VariablePrimalStart}: Attribute MathOptInterface.VariablePrimalStart() is not supported by the model.

@blegat do you know why it happens? It looks like something changed in MOI. I suspect it happened in MOI v0.8.2 wher eyou added a test in contlineartest to partially set VariablePrimalStart.

@bstellato
Copy link
Collaborator Author

Ok I have removed it for now. It looks like it is not required for OSQP from this comment

https://github.com/JuliaOpt/MathOptInterface.jl/blob/ecf691545e67552ff437ed26ec4ddfff03c50327/src/Test/contlinear.jl#L1715-L1716

@codecov-io
Copy link

codecov-io commented May 23, 2019

Codecov Report

Merging #52 into master will decrease coverage by 0.16%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   87.74%   87.58%   -0.17%     
==========================================
  Files           6        6              
  Lines         979      918      -61     
==========================================
- Hits          859      804      -55     
+ Misses        120      114       -6
Impacted Files Coverage Δ
src/types.jl 100% <ø> (ø) ⬆️
src/OSQP.jl 85.71% <ø> (ø) ⬆️
src/modcaches.jl 100% <ø> (ø) ⬆️
src/MPB_wrapper.jl 87.03% <ø> (+0.25%) ⬆️
src/MOI_wrapper.jl 90.27% <100%> (-3.93%) ⬇️
src/interface.jl 77.92% <66.66%> (+3.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0818ce...4e01fd7. Read the comment docs.

@bstellato
Copy link
Collaborator Author

Thanks! I have made the changes you suggested. I kept Compat in the test dependencies because it is needed in MathProgBase.

keywords = ["numerical-optimization", "solver"]
license = "Apache 2.0"
desc = "The Operator Splitting QP Solver."
version = "0.5.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add repo = "https://github.com/oxfordcontrol/OSQP.jl.git"

@bstellato bstellato merged commit 2e1dba7 into master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from BinDeps to BinaryBuilder Drop 0.6, 0.7?
5 participants