Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Julia 1.1. #42

Merged
merged 1 commit into from
Feb 7, 2019
Merged

Test on Julia 1.1. #42

merged 1 commit into from
Feb 7, 2019

Conversation

tkoolen
Copy link
Collaborator

@tkoolen tkoolen commented Feb 4, 2019

No description provided.

@tkoolen
Copy link
Collaborator Author

tkoolen commented Feb 4, 2019

I'm actually surprised this passes. Tests do not pass for me locally on 1.1.

I'm getting:

No CachingOptimizer: problem modification after copy_to: Test Failed at /home/twan/.julia/dev/OSQP/test/MOI_wrapper.jl:233
  Expression: twarm < 0.5tcold
   Evaluated: 0.0 < 0.0

so @bstellato, in response to #43, I do think there's something weird going on, either on the Julia side or in the solver itself.

@codecov-io
Copy link

Codecov Report

Merging #42 into master will increase coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   87.61%   88.04%   +0.43%     
==========================================
  Files           6        6              
  Lines         977      979       +2     
==========================================
+ Hits          856      862       +6     
+ Misses        121      117       -4
Impacted Files Coverage Δ
src/interface.jl 74.32% <0%> (+0.38%) ⬆️
src/MOI_wrapper.jl 94.98% <0%> (+0.8%) ⬆️
src/OSQP.jl 85.71% <0%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23a1303...dab2a84. Read the comment docs.

@tkoolen tkoolen merged commit e9c9afa into master Feb 7, 2019
@tkoolen tkoolen deleted the tk/test-1.1 branch February 7, 2019 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants