Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong attribute in processdualstart() #40

Closed
migarstka opened this issue Jan 24, 2019 · 2 comments
Closed

Wrong attribute in processdualstart() #40

migarstka opened this issue Jan 24, 2019 · 2 comments

Comments

@migarstka
Copy link
Collaborator

migarstka commented Jan 24, 2019 •
edited by blegat
Loading

I think I spotted a bug in the processdualstart() function of the MOIWrapper.

The line:

https://github.com/oxfordcontrol/OSQP.jl/blob/8dd46b5a7c8955ae41cf8464295825801946e939/src/MOI_wrapper.jl#L369

should be replaced with

if attr isa MOI.ConstraintDualStart
@blegat
Copy link
Collaborator

blegat commented Jan 24, 2019

Indeed, want to make a PR ?

migarstka added a commit to migarstka/OSQP.jl that referenced this issue Jan 24, 2019
@migarstka
<osqp#40> Fix wrong attribute in processdualstart!()
18f2f95 
- Change MOI.VariablePrimalStart to MOI.ConstraintDualStart in processdualstart!()
@migarstka
Copy link
Collaborator Author

Addressed in #41

blegat added a commit that referenced this issue Feb 1, 2019
@blegat
Merge pull request #41 from migarstka/mg/attribute-fix
23a1303 
<#40> Fix wrong attribute in processdualstart!()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blegat @migarstka