Refactor to hexagonal architechture #59
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
| public ResponseEntity<Album> addAlbum(@Valid @RequestBody AlbumRequest albumRequest, @CurrentUser UserPrincipal currentUser) { | ||
| return albumService.addAlbum(albumRequest, currentUser); | ||
| } | ||
| @PostMapping |
There was a problem hiding this comment.
this can point to something linke ("api/createAlbum') or addAlbum
| return categoryService.getAllCategories(page, size); | ||
| } | ||
|
|
||
| @PostMapping |
There was a problem hiding this comment.
also this can point to /addCategory or createCategory
| return UserPrincipal.create(user); | ||
| } | ||
| @Override | ||
| @Transactional |
There was a problem hiding this comment.
this should sit within the interface not in the implementation
There was a problem hiding this comment.
Nice Work ! would be great approach to have your custom queries, have Repository Interface, ServiceInterface ( for your custom extra methods ) and ServiceImpl for your logic and also setting up the beans on the xml file
|
SonarCloud Quality Gate failed.
|
No description provided.