Highlighted special devices, added logo and removed unicodes from port description #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guyluz11 Fixed some of the issues, I'm still working on rest of them. |
git-elliot
changed the title
git-elliot
changed the title
git-elliot
added
the
enhancement
This was
linked to
issues
Jan 22, 2022
guyluz11
requested changes
Jan 22, 2022
lib/pages/host_scan_page.dart
Outdated
| double _progress = 0; | ||
| bool _isScanning = false; | ||
| StreamSubscription<ActiveHost>? _streamSubscription; | ||
| late String? ip; |
There was a problem hiding this comment.
Not clear about some parts in this page, like why is this not local variable.
Will check it out later as I am on the phone
There was a problem hiding this comment.
It should be private but not local, since I'm saving the result of NetworkInfo calls for latter use when giving name and icon to the device.
lib/pages/host_scan_page.dart
Outdated
| ip = await NetworkInfo().getWifiIP(); | ||
| gatewayIp = await NetworkInfo().getWifiGatewayIP(); | ||
|
|
||
| debugPrint('wifi ip : $ip'); |
There was a problem hiding this comment.
Don't forget to remove in the end
guyluz11
requested changes
Jan 22, 2022
guyluz11
reviewed
Jan 23, 2022
guyluz11
reviewed
Jan 23, 2022
lib/pages/host_scan_page.dart
Outdated
| (ActiveHost device) { | ||
| debugPrint('Found device: ${device.ip}'); | ||
| (ActiveHost host) { | ||
| debugPrint('Found host: ${host.ip}'); |
There was a problem hiding this comment.
Debug does not need to be included in the production, please remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for