Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code of this package should be based on the implementations of network_tools and override only the necessary parts that require flutter platform-specific override.
In order to achieve that I have changed the package to use inheritance of services, this will make development and code easier to maintain.
Another benefit is that users call the method exactly the same way as network tools
Old
network_tools:
HostScanner.x();
network_tools_flutter
HostScannerFlutter.x();
New
network_tools:
HostScannerService.instance.x();
network_tools_flutter
HostScannerService.instance.x();
To achieve that user needs to initialize the flutter package with this method
configureNetworkToolsFlutter
at the main functionChange:
configureNetworkTools
-->configureNetworkToolsFlutter
This pr is ready but is blocked but based on osociety/network_tools#183 pr to network_tools to work so it is currently blocked.
Fix: #38
This pr does not change the package logic.