feat: SQS pricing from on-chain source #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
commented
Feb 22, 2024
Comment on lines
+33
to
+35
| // TODO: move to config | ||
| defaultQuoteHumanDenom = "usdc" | ||
| defaultPricingSource = domain.ChainPricingSource |
There was a problem hiding this comment.
Move defaultQuoteHumanDenom and defaultPricingSource to config
p0mvn
commented
Feb 22, 2024
| } | ||
|
|
||
| // GetPrice implements pricing.PricingStrategy. | ||
| func (c *chainPricing) GetPrice(ctx context.Context, baseDenom string, quoteDenom string) (osmomath.BigDec, error) { |
There was a problem hiding this comment.
Unit test GetPrice method of chainPricing
Maximize test coverage
p0mvn
commented
Feb 22, 2024
| // @Param humanDenoms query bool false "Specify true if input denominations are in human-readable format; defaults to false" | ||
| // @Success 200 {object} map[string]map[string]string "A map where each key is a base denomination (on-chain format), containing another map with a key as the quote denomination (on-chain format) and the value as the spot price." | ||
| // @Router /tokens/prices [get] | ||
| func (a *TokensHandler) GetPrices(c echo.Context) (err error) { |
There was a problem hiding this comment.
Operationalize /tokens/prices endpoint
- Load test
- Fuzz unit test with various combinations of mainnet denoms from mainnet state
- Add instrumentation
- Build dashboards
p0mvn
commented
Feb 22, 2024
| }, nil | ||
| } | ||
|
|
||
| // GetDenomPrecisions implements domain.TokensUsecase. | ||
| func (t *tokensUseCase) GetDenomPrecisions(ctx context.Context) (map[string]int, error) { | ||
| // GetChainDenom implements mvc.TokensUsecase. |
There was a problem hiding this comment.
Unit test all methods in tokensUsecase
This was referenced Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.