Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BE-586 | Claimbot #524
BE-586 | Claimbot #524
Changes from 28 commits
cd919d625746a1801f9f453dc4b8d349b3fdbc37eca6297883d1c9b6c548460f37ac1dad494d3ac10250b7e3e6c0183ccef139b1054d41bd92ee4b25a93a63811bfacf2084e054a4d826bc413989df2a6a94eea346cf9813c90eb83e2d5130ff913bfc39dd73216bb1b1ecbf48a8ef15adb286cd298179131ba9e172b2add11fbf2beee7692593bc0File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider adding configuration parameters for fine-grained control.
The plugin configurations could benefit from additional parameters to control their behavior:
This would provide more flexibility in different environments without requiring code changes.
Example structure:
{ "name": "orderbook-claimbot-plugin", "enabled": false, + "settings": { + "fill_threshold_percentage": 98, + "max_concurrent_orderbooks": 1, + "rate_limit": { + "orders_per_second": 10, + "max_batch_size": 50 + } + } }There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider abstracting all of the chain clients behind a struct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add input validation and consider connection management.
The constructor could be improved in several ways:
Consider adding validation and cleanup:
func NewConfig( keyring keyring.Keyring, orderbookusecase mvc.OrderBookUsecase, poolsUseCase mvc.PoolsUsecase, orderbookRepository orderbookdomain.OrderBookRepository, orderBookClient orderbookgrpcclientdomain.OrderBookClient, logger log.Logger, chainGRPCGatewayEndpoint string, chainID string, ) (*Config, error) { + if keyring == nil || orderbookusecase == nil || poolsUseCase == nil || + orderbookRepository == nil || orderBookClient == nil || logger == nil { + return nil, fmt.Errorf("all dependencies must be non-nil") + } + if chainGRPCGatewayEndpoint == "" || chainID == "" { + return nil, fmt.Errorf("chainGRPCGatewayEndpoint and chainID must not be empty") + } + grpcClient, err := grpc.NewClient(chainGRPCGatewayEndpoint) if err != nil { return nil, err } + + cfg := &Config{ + Keyring: keyring, + PoolsUseCase: poolsUseCase, + OrderbookUsecase: orderbookusecase, + OrderbookRepository: orderbookRepository, + OrderBookClient: orderBookClient, + AccountQueryClient: authtypes.NewQueryClient(grpcClient), + TxfeesClient: txfeestypes.NewQueryClient(grpcClient), + GasCalculator: sqstx.NewGasCalculator(grpcClient), + TxServiceClient: txtypes.NewServiceClient(grpcClient), + Logger: logger, + ChainID: chainID, + MinimumFillPercentage: 0.98, // Default to 98% as mentioned in PR objectives + } + + // Add cleanup method + runtime.SetFinalizer(cfg, func(c *Config) { + if conn, ok := grpcClient.(*grpc.ClientConn); ok { + _ = conn.Close() + } + }) + - return &Config{ - Keyring: keyring, - PoolsUseCase: poolsUseCase, - OrderbookUsecase: orderbookusecase, - OrderbookRepository: orderbookRepository, - OrderBookClient: orderBookClient, - AccountQueryClient: authtypes.NewQueryClient(grpcClient), - TxfeesClient: txfeestypes.NewQueryClient(grpcClient), - GasCalculator: sqstx.NewGasCalculator(grpcClient), - TxServiceClient: txtypes.NewServiceClient(grpcClient), - Logger: logger, - ChainID: chainID, - }, nil + return cfg, nil