SQS-417 | Fix orderbook order Quantity parsing

[deividaspetraitis]

This PR fixes order Quantity parsing that previously caused an error and made some orders not appear in the returned list

Summary by CodeRabbit

• New Features

  • Enhanced order status determination with improved quantity parsing, now supporting decimal representation for better accuracy.

• Bug Fixes

  • Updated comparison logic for order quantity to ensure more precise status assessment.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes involve modifications to the Status method of the Order struct in the orderbookdomain package. The method's logic for parsing the Quantity field has been updated from using strconv.Atoi to osmomath.NewDecFromStr, allowing for decimal representation. Additionally, the comparison of quantity against zero has been changed to utilize the IsZero method from the osmomath package, enhancing the precision of order status determination based on the filled percentage.

Changes

File Path	Change Summary
domain/orderbook/order.go	Updated Status method to parse Quantity using osmomath.NewDecFromStr and modified zero comparison to use IsZero method from osmomath.

Possibly related PRs

• SQS-347 | integration, synthetic monitoring tests for active orders #504: This PR introduces tests for active orders, which may indirectly relate to the changes in the Order struct's Status method, as both involve order management functionality.
• SQS-406 | E2E Tests: Increase expected latency upper bound for /passthrough/active-orders enpoint #514: This PR modifies the expected latency for the /passthrough/active-orders endpoint, which could be relevant since it deals with the performance of order-related queries.
• SQS-406 | E2E Tests: Increase expected latency upper bound for /passthrough/active-orders enpoind ( backport ) #517: Similar to SQS-406 | E2E Tests: Increase expected latency upper bound for /passthrough/active-orders enpoint #514, this backport PR also adjusts the expected latency for the /passthrough/active-orders endpoint, maintaining relevance to the order management context.

Suggested reviewers

• p0mvn
• cryptomatictrader

Poem

In the orderbook, a change so bright,
Quantities now dance in decimal light.
From strings to math, precision's the key,
Orders now flow, as smooth as can be.
Hooray for the tweaks, let's hop with delight! 🐰✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud